London| 26-jul-sdc| ShaghayeghShirinfar| Sprint 1 | Number System#547
Open
shaghayeghfar wants to merge 3 commits into
Open
London| 26-jul-sdc| ShaghayeghShirinfar| Sprint 1 | Number System#547shaghayeghfar wants to merge 3 commits into
shaghayeghfar wants to merge 3 commits into
Conversation
shaghayeghfar
added
📅 Sprint 1
LonMcGregor
added
Needs Review
LonMcGregor
added
Needs Review
This comment has been minimized.
This comment has been minimized.
OracPrime
suggested changes
Jul 10, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
All the answers are good, but you need to remove the .idea folder from your submission.
OracPrime
added
Reviewed
This comment has been minimized.
This comment has been minimized.
OracPrime
reviewed
Jul 10, 2026
| @@ -1,2 +1,3 @@ | |||
| node_modules | |||
| testoutput.txt | |||
| .idea/ | |||
There was a problem hiding this comment.
Excellent. To get a second review done, you need to re-add the NeedsReview tag, or no-one will see it.
Author
There was a problem hiding this comment.
Thank you very much for your help and advice.
shaghayeghfar
added
Needs Review
|
Results of test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Practiced understanding binary and hex numbers manually.